Parse signals after <child> tags and add tests. (#468793, Benjamin Otte)

2007-10-24  Johan Dahlin  <jdahlin@async.com.br>

	* gtk/gtkbuilder.c: (_gtk_builder_construct),
	(_gtk_builder_add_signals):
	* gtk/gtkbuilderparser.c: (end_element):
	* gtk/gtkbuilderprivate.h:
	* tests/buildertest.c: (test_connect_signals):

	Parse signals after <child> tags and add tests.
	(#468793, Benjamin Otte)

svn path=/trunk/; revision=18944

diff --git a/ChangeLog b/ChangeLog
index 6ed403f7ce0b9cc3000a98b790f1e3f06b724872..d73a15a7473b8c7236d02fd7b96532611ae31f01 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2007-10-24  Johan Dahlin  <jdahlin@async.com.br>
+
+       * gtk/gtkbuilder.c: (_gtk_builder_construct),
+       (_gtk_builder_add_signals):
+       * gtk/gtkbuilderparser.c: (end_element):
+       * gtk/gtkbuilderprivate.h:
+       * tests/buildertest.c: (test_connect_signals):
+
+       Parse signals after <child> tags and add tests.
+       (#468793, Benjamin Otte)
+
 2007-10-24  Johan Dahlin  <jdahlin@async.com.br>
 
        * gtk/gtkbuilderparser.c (end_element): Allow empty property nodes

diff --git a/gtk/gtkbuilder.c b/gtk/gtkbuilder.c
index 5f4566dbe55b90d6b4909641b134ee9102ce8bfa..1ab9acbca0964767386d12a635385c18c5b840f9 100644 (file)
--- a/gtk/gtkbuilder.c
+++ b/gtk/gtkbuilder.c
@@ -497,8 +497,6 @@ _gtk_builder_construct (GtkBuilder *builder,
     }
   g_hash_table_insert (builder->priv->objects, g_strdup (info->id), obj);
   
-  builder->priv->signals = g_slist_concat (builder->priv->signals,
-                                           g_slist_copy (info->signals));
   return obj;
 }
 
@@ -545,6 +543,14 @@ _gtk_builder_add (GtkBuilder *builder,
   child_info->added = TRUE;
 }
 
+void
+_gtk_builder_add_signals (GtkBuilder *builder,
+                         GSList     *signals)
+{
+  builder->priv->signals = g_slist_concat (builder->priv->signals,
+                                           g_slist_copy (signals));
+}
+
 static void
 apply_delayed_properties (const gchar *window_name,
                           GSList      *props,

diff --git a/gtk/gtkbuilderparser.c b/gtk/gtkbuilderparser.c
index af3a826fd4264a967599be8766fb8683d49ee2d2..3ca1d3c31d2889cea7d9bdd2f5bf236a08205c32 100644 (file)
--- a/gtk/gtkbuilderparser.c
+++ b/gtk/gtkbuilderparser.c
@@ -774,6 +774,8 @@ end_element (GMarkupParseContext *context,
       if (GTK_IS_BUILDABLE (object_info->object) &&
           GTK_BUILDABLE_GET_IFACE (object_info->object)->parser_finished)
         data->finalizers = g_slist_prepend (data->finalizers, object_info->object);
+      _gtk_builder_add_signals (data->builder, object_info->signals);
+
       free_object_info (object_info);
     }
   else if (strcmp (element_name, "property") == 0)

diff --git a/gtk/gtkbuilderprivate.h b/gtk/gtkbuilderprivate.h
index 1c3f18e68a6fd493509095bd8c5a27bc24883c38..8277fa792b6e817732b4398c3de0db1163b55635 100644 (file)
--- a/gtk/gtkbuilderprivate.h
+++ b/gtk/gtkbuilderprivate.h
@@ -105,6 +105,8 @@ GObject * _gtk_builder_construct (GtkBuilder *builder,
                                   ObjectInfo *info);
 void      _gtk_builder_add (GtkBuilder *builder,
                             ChildInfo *child_info);
+void      _gtk_builder_add_signals (GtkBuilder *builder,
+                                   GSList     *signals);
 void      _gtk_builder_finish (GtkBuilder *builder);
 void _free_signal_info (SignalInfo *info,
                         gpointer user_data);

diff --git a/tests/buildertest.c b/tests/buildertest.c
index 72b25e033725783161c5b7d9270166dda6669bd4..079e12d2817e1c1206c6fc0ee19bdeef8653f392 100644 (file)
--- a/tests/buildertest.c
+++ b/tests/buildertest.c
@@ -189,6 +189,15 @@ gboolean test_connect_signals (void)
     "    <signal name=\"notify::title\" handler=\"signal_extra2\"/>"
     "  </object>"
     "</interface>";
+  const gchar buffer_after_child[] =
+    "<interface>"
+    "  <object class=\"GtkWindow\" id=\"window1\">"
+    "    <child>"
+    "      <object class=\"GtkButton\" id=\"button1\"/>"
+    "    </child>"
+    "    <signal name=\"notify::title\" handler=\"signal_normal\"/>"
+    "  </object>"
+    "</interface>";
 
   builder = builder_new_from_string (buffer, -1, NULL);
   gtk_builder_connect_signals (builder, NULL);
@@ -229,6 +238,19 @@ gboolean test_connect_signals (void)
   
   g_object_unref (builder);
 
+  /* new test, reset globals */
+  after = 0;
+  normal = 0;
+  
+  builder = builder_new_from_string (buffer_after_child, -1, NULL);
+  window = gtk_builder_get_object (builder, "window1");
+  gtk_builder_connect_signals (builder, NULL);
+  gtk_window_set_title (GTK_WINDOW (window), "test");
+
+  g_return_val_if_fail (normal == 1, FALSE);
+  gtk_widget_destroy (GTK_WIDGET (window));
+  g_object_unref (builder);
+  
   return TRUE;
 }